app: update url on listening event - #357
Merged
Merged
Conversation
Most applications report the URL when started (at least the apps we are scaffolding using loopback-workspace). Constructing the URL in the loopback core allows us to simplify the templates and reduce the amount of repeated code.
Member
|
LGTM |
bajtos
added a commit
that referenced
this pull request
Jul 1, 2014
app: update `url` on `listening` event
bajtos
pushed a commit
that referenced
this pull request
Jul 1, 2014
Land the pull request #357 > app: update `url` on `listening` event
This was referenced Jul 2, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most applications report the URL when started (at least the apps we
are scaffolding using loopback-workspace). Constructing the URL in the
loopback core allows us to simplify the templates and reduce the amount
of repeated code.
/to @ritch please review
Once this is landed in both
masterand2.0, I will simplify the templates in loopback-workspace 3.0.